hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner" <ghagleit...@hortonworks.com>
Subject Re: Review Request 26481: HIVE-8411: Support partial partition spec for certain ALTER PARTITION statements
Date Thu, 16 Oct 2014 07:32:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26481/#review56905
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/26481/#comment97340>

    there's a flag for enabling dynamic partitioning. is this checked somewhere in this path?
ppl use that to avoid someone accidentally changing everything.



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/26481/#comment97339>

    why does this fail? it seems more consistent to just alter 0 partitions in this case.
or at least just print a warning instead of failing.



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/26481/#comment97341>

    LOG.error?



ql/src/test/queries/clientpositive/alter_partition_change_col.q
<https://reviews.apache.org/r/26481/#comment97342>

    does this support multi level partitioning? if so can you specify only some of the partitions?



ql/src/test/queries/clientpositive/alter_partition_change_col.q
<https://reviews.apache.org/r/26481/#comment97343>

    add a query to verify the output?


- Gunther Hagleitner


On Oct. 9, 2014, 3:14 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26481/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 3:14 a.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Thejas Nair.
> 
> 
> Bugs: HIVE-8411
>     https://issues.apache.org/jira/browse/HIVE-8411
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Allow partial partition spec for some alter table statements, such as:
> 
> alter table alter_partition_change_col1 partition (p1) change column c2 c2 decimal(10,0);
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d5374bc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 4e58ad8 
>   ql/src/test/queries/clientpositive/alter_partition_change_col.q baabb9f 
>   ql/src/test/results/clientpositive/alter_partition_change_col.q.out 7123e40 
> 
> Diff: https://reviews.apache.org/r/26481/diff/
> 
> 
> Testing
> -------
> 
> updated qfile test
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message