hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion
Date Wed, 15 Oct 2014 21:39:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26721/#review56817
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java
<https://reviews.apache.org/r/26721/#comment97245>

    Why are we recomputing the digest here?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97246>

    This change seems just inversion of logic.
    Does Hive Coding convention proposes this?



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97247>

    Is this needed now, since we did the check before  'fixTopOBSchema'



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
<https://reviews.apache.org/r/26721/#comment97248>

    Why is this wrong?



ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java
<https://reviews.apache.org/r/26721/#comment97249>

    Instead of introducing a new class why don't you return a Pair<Boolean, Integer>


- John Pullokkaran


On Oct. 15, 2014, 12:44 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26721/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 12:44 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java
7b434ea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/ASTConverter.java
f5a704f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java
4f96d02 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 9c55379 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1eca13 
>   ql/src/test/queries/clientpositive/select_same_col.q PRE-CREATION 
>   ql/src/test/results/clientpositive/select_same_col.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message