hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <jxi...@cloudera.com>
Subject Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList
Date Wed, 15 Oct 2014 12:55:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26661/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 12:55 p.m.)


Review request for hive and Xuefu Zhang.


Changes
-------

The new patch made HiveKVResultCache fully thread safe as Xuefu suggested.


Bugs: HIVE-7873
    https://issues.apache.org/jira/browse/HIVE-7873


Repository: hive-git


Description
-------

Re-enabled lazy HiveBaseFunctionResultList. A separate RowContainer is used to work around
the no-write-after-read limitation of RowContainer. The patch also fixed a concurrency issue
in HiveKVResultCache. Synchronized is used instead of reentrant lock since I assume there
won't be many threads to access the cache.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 0df2580

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.java a6b9037 
  ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestHiveKVResultCache.java 496a11f 

Diff: https://reviews.apache.org/r/26661/diff/


Testing
-------

Unit test, some simple perf test.


Thanks,

Jimmy Xiang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message