hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <>
Subject Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList
Date Wed, 15 Oct 2014 12:55:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 15, 2014, 12:55 p.m.)

Review request for hive and Xuefu Zhang.


The new patch made HiveKVResultCache fully thread safe as Xuefu suggested.

Bugs: HIVE-7873

Repository: hive-git


Re-enabled lazy HiveBaseFunctionResultList. A separate RowContainer is used to work around
the no-write-after-read limitation of RowContainer. The patch also fixed a concurrency issue
in HiveKVResultCache. Synchronized is used instead of reentrant lock since I assume there
won't be many threads to access the cache.

Diffs (updated)

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ 0df2580

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ a6b9037 
  ql/src/test/org/apache/hadoop/hive/ql/exec/spark/ 496a11f 



Unit test, some simple perf test.


Jimmy Xiang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message