hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
Date Fri, 03 Oct 2014 20:59:09 GMT


> On Oct. 3, 2014, 7:06 p.m., Vaibhav Gumashta wrote:
> > bin/ext/hiveserver2.cmd, line 82
> > <https://reviews.apache.org/r/26321/diff/1/?file=713542#file713542line82>
> >
> >     I don't think the "-hiveconf" paramaters should be part of the cmd. I see that
you are trying to override the default value of some of these, but I think it is more appropriate
to do that at the admin level (i.e. whichever admin service is managing the startup of hive).

Explained by Hari here: https://issues.apache.org/jira/browse/HIVE-8340?focusedCommentId=14158506&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14158506


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26321/#review55378
-----------------------------------------------------------


On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26321/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 6:27 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> On stopping the HS2 service from the services tab, it only kills the root process and
does not kill the child java process. As a result resources are not freed and this throws
an error on restarting from command line.
> 
> 
> Diffs
> -----
> 
>   bin/ext/hiveserver2.cmd a5f3bb5 
>   bin/hive.cmd c2e9853 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 
> 
> Diff: https://reviews.apache.org/r/26321/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> XIAOBING ZHOU
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message