Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3AF0177CD for ; Tue, 30 Sep 2014 14:25:34 +0000 (UTC) Received: (qmail 68096 invoked by uid 500); 30 Sep 2014 14:25:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 68021 invoked by uid 500); 30 Sep 2014 14:25:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 68010 invoked by uid 500); 30 Sep 2014 14:25:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 68007 invoked by uid 99); 30 Sep 2014 14:25:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Sep 2014 14:25:34 +0000 Date: Tue, 30 Sep 2014 14:25:34 +0000 (UTC) From: "Ted Yu (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153220#comment-14153220 ] Ted Yu commented on HIVE-8285: ------------------------------ +1 > Reference equality is used on boolean values in PartitionPruner#removeTruePredciates() > -------------------------------------------------------------------------------------- > > Key: HIVE-8285 > URL: https://issues.apache.org/jira/browse/HIVE-8285 > Project: Hive > Issue Type: Bug > Affects Versions: 0.14.0 > Reporter: Ted Yu > Priority: Minor > Attachments: HIVE-8285.patch > > > {code} > if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo > && eC.getValue() == Boolean.TRUE) { > {code} > equals() should be used in the above comparison. -- This message was sent by Atlassian JIRA (v6.3.4#6332)