Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A428C111DD for ; Tue, 2 Sep 2014 05:14:21 +0000 (UTC) Received: (qmail 59826 invoked by uid 500); 2 Sep 2014 05:14:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 59743 invoked by uid 500); 2 Sep 2014 05:14:21 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 59730 invoked by uid 500); 2 Sep 2014 05:14:21 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 59727 invoked by uid 99); 2 Sep 2014 05:14:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 05:14:21 +0000 Date: Tue, 2 Sep 2014 05:14:21 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-7868) AvroSerDe error handling could be improved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117901#comment-14117901 ] Brock Noland commented on HIVE-7868: ------------------------------------ Actually AvroSerde does as I describe above. What I was really thinking here is that we should somehow improve the error message provided to the user. We might had a message to Serde getConfigurationErrors(). We can add a default implementation to AbstractSerde which returns an empty list. Then we can update the callers to check for this before using a Serde. These messages can be disabled when we describe an avro backed table. > AvroSerDe error handling could be improved > ------------------------------------------ > > Key: HIVE-7868 > URL: https://issues.apache.org/jira/browse/HIVE-7868 > Project: Hive > Issue Type: Improvement > Reporter: Brock Noland > Assignee: Ferdinand Xu > > When an Avro schema is invalid, AvroSerDe returns an error message instead of throwing an exception. This is described in {{AvroSerdeUtils.determineSchemaOrReturnErrorSchema}}: > {noformat} > /** > * Attempt to determine the schema via the usual means, but do not throw > * an exception if we fail. Instead, signal failure via a special > * schema. This is used because Hive calls init on the serde during > * any call, including calls to update the serde properties, meaning > * if the serde is in a bad state, there is no way to update that state. > */ > {noformat} > I believe we should find a way to provide a better experience to our users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)