Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 049F917C3E for ; Tue, 30 Sep 2014 00:04:46 +0000 (UTC) Received: (qmail 28929 invoked by uid 500); 30 Sep 2014 00:04:45 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28846 invoked by uid 500); 30 Sep 2014 00:04:45 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28829 invoked by uid 99); 30 Sep 2014 00:04:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Sep 2014 00:04:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 429951DDB1A; Tue, 30 Sep 2014 00:04:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6145018931483721370==" MIME-Version: 1.0 Subject: Re: Review Request 26120: HIVE-8278 - Restoring a graph representation of SparkPlan [Spark Branch] From: "Chao Sun" To: "Xuefu Zhang" Cc: "hive" , "Chao Sun" Date: Tue, 30 Sep 2014 00:04:42 -0000 Message-ID: <20140930000442.19041.83180@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26120/ X-Sender: "Chao Sun" References: <20140929233447.19041.51724@reviews.apache.org> In-Reply-To: <20140929233447.19041.51724@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============6145018931483721370== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 29, 2014, 11:34 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java, line 34 > > > > > > Do we need rootTrans? I thought rootTrans is just the same as the keyset of mapInputs, so I removed it. Correct me if I'm wrong. > On Sept. 29, 2014, 11:34 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java, line 72 > > > > > > So we are not do union of those any more? I forgot ... now fixed. - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26120/#review54904 ----------------------------------------------------------- On Sept. 29, 2014, 8:16 p.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26120/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 8:16 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8278 > https://issues.apache.org/jira/browse/HIVE-8278 > > > Repository: hive-git > > > Description > ------- > > HIVE-8249 greatly simply file the SparkPlan model and the SparkPlanGenerator logic. As a side effect, however, a visual representation of SparkPlan got lost. Such representation is helpful for debugging and performance profiling. In addition, it would be also good to separate plan generation and plan execution. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java f8b3283 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 15af0f9 > > Diff: https://reviews.apache.org/r/26120/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > > --===============6145018931483721370==--