Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7C4B11977 for ; Mon, 22 Sep 2014 02:23:45 +0000 (UTC) Received: (qmail 75808 invoked by uid 500); 22 Sep 2014 02:23:45 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 75738 invoked by uid 500); 22 Sep 2014 02:23:45 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 75720 invoked by uid 99); 22 Sep 2014 02:23:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 02:23:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CF76D1DD932; Mon, 22 Sep 2014 02:23:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5062478870112167251==" MIME-Version: 1.0 Subject: Re: Review Request 25834: HIVE-8138 - Global Init file should allow specifying file name not only directory From: "Dong Chen" To: "Dong Chen" , "hive" , "Brock Noland" Date: Mon, 22 Sep 2014 02:23:42 -0000 Message-ID: <20140922022342.15006.50216@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dong Chen" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25834/ X-Sender: "Dong Chen" References: <20140919172833.16263.52860@reviews.apache.org> In-Reply-To: <20140919172833.16263.52860@reviews.apache.org> Reply-To: "Dong Chen" X-ReviewRequest-Repository: hive-git --===============5062478870112167251== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25834/#review54107 ----------------------------------------------------------- service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java Shall we add a newline here? To make the coding style better. The patch looks good! I only have a very small comment here. - Dong Chen On Sept. 19, 2014, 5:28 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25834/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 5:28 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Allows either a file or dir. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a045b7 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 5231d5e > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 5b1cbc0 > > Diff: https://reviews.apache.org/r/25834/diff/ > > > Testing > ------- > > > Thanks, > > Brock Noland > > --===============5062478870112167251==--