Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA042115E4 for ; Sun, 21 Sep 2014 04:18:53 +0000 (UTC) Received: (qmail 60328 invoked by uid 500); 21 Sep 2014 04:18:53 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 60253 invoked by uid 500); 21 Sep 2014 04:18:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 60241 invoked by uid 99); 21 Sep 2014 04:18:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Sep 2014 04:18:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DF6531DD919; Sun, 21 Sep 2014 04:18:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0954849650133959912==" MIME-Version: 1.0 Subject: Re: Review Request 25800: inconsistence between colList and columnExprMap when ConstantPropagate is applied to subquery From: "pengcheng xiong" To: "pengcheng xiong" , "hive" Date: Sun, 21 Sep 2014 04:18:50 -0000 Message-ID: <20140921041850.26300.36879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25800/ X-Sender: "pengcheng xiong" References: <20140919185517.7800.70885@reviews.apache.org> In-Reply-To: <20140919185517.7800.70885@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============0954849650133959912== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25800/ ----------------------------------------------------------- (Updated Sept. 21, 2014, 4:18 a.m.) Review request for hive. Changes ------- update golden files Repository: hive-git Description ------- Query like select * from (select a.key as ak, a.value as av, b.key as bk, b.value as bv from src a join src1 b where a.key = '428' ) c; will fail as FAILED: Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 790a92e ql/src/test/queries/clientpositive/constantPropagateForSubQuery.q PRE-CREATION ql/src/test/results/clientpositive/annotate_stats_select.q.out 1b3b334 ql/src/test/results/clientpositive/auto_join8.q.out 2e3d1c8 ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out PRE-CREATION ql/src/test/results/clientpositive/join8.q.out 6435b92 ql/src/test/results/clientpositive/join_view.q.out 3e54177 ql/src/test/results/clientpositive/lateral_view_ppd.q.out 756679a ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 221ee70 ql/src/test/results/clientpositive/ppd_repeated_alias.q.out f51b5a3 ql/src/test/results/clientpositive/select_dummy_source.q.out 651ce1d ql/src/test/results/clientpositive/subquery_multiinsert.q.out 399c4f8 ql/src/test/results/clientpositive/subquery_notin.q.out d0e50b9 ql/src/test/results/clientpositive/subquery_notin_having.q.out 91581de ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out fe99821 ql/src/test/results/clientpositive/subquery_views.q.out 472fa10 ql/src/test/results/clientpositive/udf4.q.out 9ea9293 ql/src/test/results/clientpositive/udf7.q.out 05f2037 ql/src/test/results/clientpositive/udf_case.q.out 7eab4ab ql/src/test/results/clientpositive/udf_elt.q.out fe6c856 ql/src/test/results/clientpositive/udf_when.q.out fb262a7 ql/src/test/results/clientpositive/vector_elt.q.out 55f63b7 ql/src/test/results/compiler/plan/cast1.q.xml fe34e5b ql/src/test/results/compiler/plan/groupby1.q.xml b895372 ql/src/test/results/compiler/plan/groupby2.q.xml 46a7a5f ql/src/test/results/compiler/plan/groupby3.q.xml 5b6af21 ql/src/test/results/compiler/plan/groupby4.q.xml 92086c3 ql/src/test/results/compiler/plan/groupby5.q.xml 26e59d9 ql/src/test/results/compiler/plan/groupby6.q.xml 87e83c9 ql/src/test/results/compiler/plan/join8.q.xml 2fd7a37 ql/src/test/results/compiler/plan/udf1.q.xml e34f4d1 ql/src/test/results/compiler/plan/udf4.q.xml d6dab9e ql/src/test/results/compiler/plan/udf6.q.xml 37b969c ql/src/test/results/compiler/plan/udf_case.q.xml 726f290 ql/src/test/results/compiler/plan/udf_when.q.xml 4179e6b ql/src/test/results/compiler/plan/union.q.xml 2808b05 Diff: https://reviews.apache.org/r/25800/diff/ Testing ------- Thanks, pengcheng xiong --===============0954849650133959912==--