Return-Path: 
 <dev-return-103109-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 37ECC11733
	for <apmail-hive-dev-archive@www.apache.org>;
 Tue, 16 Sep 2014 17:30:27 +0000 (UTC)
Received: (qmail 99692 invoked by uid 500); 16 Sep 2014 17:30:26 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 99611 invoked by uid 500); 16 Sep 2014 17:30:26 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 99594 invoked by uid 99); 16 Sep 2014 17:30:26 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 17:30:26 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id B0E4C1DD77F;
	Tue, 16 Sep 2014 17:30:22 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8473722082238345903=="
MIME-Version: 1.0
Subject: Re: Review Request 25700: HIVE-8080 CBO: function name may not match
 UDF name during translation
From: "John Pullokkaran" <jpullokkaran@hortonworks.com>
To: "John Pullokkaran" <jpullokkaran@hortonworks.com>,
 "Ashutosh Chauhan" <hashutosh@apache.org>
Cc: "Sergey Shelukhin" <sergey@hortonworks.com>, "hive" <dev@hive.apache.org>
Date: Tue, 16 Sep 2014 17:30:19 -0000
Message-ID: <20140916173019.7800.81231@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "John Pullokkaran" <noreply@reviews.apache.org>
X-ReviewGroup: hive
X-ReviewRequest-URL: https://reviews.apache.org/r/25700/
X-Sender: "John Pullokkaran" <noreply@reviews.apache.org>
References: <20140916172317.7803.83992@reviews.apache.org>
In-Reply-To: <20140916172317.7803.83992@reviews.apache.org>
Reply-To: "John Pullokkaran" <jpullokkaran@hortonworks.com>
X-ReviewRequest-Repository: hive-git

--===============8473722082238345903==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25700/#review53546
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/25700/#comment93239>

    Is hive token case insensitive or all function names are in lower case?



ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/25700/#comment93240>

    are all functions qualified in hive (w.r.t DB)
    How about built in functions like "toLower"?
    Could you say <DB NAME>.toLower()?


- John Pullokkaran


On Sept. 16, 2014, 5:23 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25700/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 5:23 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c503bbb 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java PRE-CREATION 
>   ql/src/test/queries/clientpositive/create_func1.q ad924d3 
>   ql/src/test/results/clientpositive/create_func1.q.out 798f77f 
> 
> Diff: https://reviews.apache.org/r/25700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


--===============8473722082238345903==--