Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BF9811F75 for ; Tue, 16 Sep 2014 05:16:31 +0000 (UTC) Received: (qmail 46460 invoked by uid 500); 16 Sep 2014 05:16:30 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 46372 invoked by uid 500); 16 Sep 2014 05:16:30 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 46355 invoked by uid 99); 16 Sep 2014 05:16:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 05:16:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9100A1DD771; Tue, 16 Sep 2014 05:16:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7725528206629366417==" MIME-Version: 1.0 Subject: Re: Review Request 25679: Let CBO handle field expression in join condition From: "John Pullokkaran" To: "John Pullokkaran" Cc: "Ashutosh Chauhan" , "hive" Date: Tue, 16 Sep 2014 05:16:28 -0000 Message-ID: <20140916051628.7803.40005@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Pullokkaran" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25679/ X-Sender: "John Pullokkaran" References: <20140916020755.7800.64743@reviews.apache.org> In-Reply-To: <20140916020755.7800.64743@reviews.apache.org> Reply-To: "John Pullokkaran" X-ReviewRequest-Repository: hive-git --===============7725528206629366417== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25679/#review53467 ----------------------------------------------------------- Ship it! Ship It! - John Pullokkaran On Sept. 16, 2014, 2:07 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25679/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 2:07 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-8117 > https://issues.apache.org/jira/browse/HIVE-8117 > > > Repository: hive-git > > > Description > ------- > > Let CBO handle field expression in join condition > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/JoinTypeCheckCtx.java b9bac9f > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 11bd103 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1e60f7b > > Diff: https://reviews.apache.org/r/25679/diff/ > > > Testing > ------- > > mapjoin1.q > > > Thanks, > > Ashutosh Chauhan > > --===============7725528206629366417==--