Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 149FF11B54 for ; Fri, 12 Sep 2014 21:50:48 +0000 (UTC) Received: (qmail 53302 invoked by uid 500); 12 Sep 2014 21:50:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 53232 invoked by uid 500); 12 Sep 2014 21:50:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 53217 invoked by uid 99); 12 Sep 2014 21:50:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 21:50:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 52B471DD74D; Fri, 12 Sep 2014 21:50:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1346192758523737190==" MIME-Version: 1.0 Subject: Review Request 25595: HIVE-8083: Authorization DDLs should not enforce hive identifier syntax for user or group namesname that From: "Prasad Mujumdar" To: "Brock Noland" Cc: "Prasad Mujumdar" , "hive" Date: Fri, 12 Sep 2014 21:50:45 -0000 Message-ID: <20140912215045.23923.86262@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Prasad Mujumdar" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25595/ X-Sender: "Prasad Mujumdar" Reply-To: "Prasad Mujumdar" X-ReviewRequest-Repository: hive-git --===============1346192758523737190== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25595/ ----------------------------------------------------------- Review request for hive and Brock Noland. Bugs: HIVE-8083 https://issues.apache.org/jira/browse/HIVE-8083 Repository: hive-git Description ------- The compiler expects principals (user, group and role) as hive identifiers for authorization DDLs. The user and group are entities that belong to external namespace and we can't expect those to follow hive identifier syntax rules. For example, a userid or group can contain '-' which is not allowed by compiler. The patch is to allow string literal for user and group names. The quoted identifier support perhaps can be made to work with this. However IMO this syntax should be supported regardless of quoted identifier support (which is an optional configuration) Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 25cd3a5 ql/src/test/queries/clientpositive/authorization_non_id.q PRE-CREATION ql/src/test/results/clientpositive/authorization_non_id.q.out PRE-CREATION Diff: https://reviews.apache.org/r/25595/diff/ Testing ------- Added test case to verify various auth DDLs with new syntax. Thanks, Prasad Mujumdar --===============1346192758523737190==--