Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 01F4C1117C for ; Wed, 10 Sep 2014 20:31:30 +0000 (UTC) Received: (qmail 99338 invoked by uid 500); 10 Sep 2014 20:31:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 99261 invoked by uid 500); 10 Sep 2014 20:31:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 99243 invoked by uid 99); 10 Sep 2014 20:31:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 20:31:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 95A061DD61E; Wed, 10 Sep 2014 20:31:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1209798032280787402==" MIME-Version: 1.0 Subject: Re: Review Request 25513: Handle repeated alias. From: "John Pullokkaran" To: "John Pullokkaran" Cc: "Ashutosh Chauhan" , "hive" Date: Wed, 10 Sep 2014 20:31:27 -0000 Message-ID: <20140910203127.23923.65408@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Pullokkaran" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25513/ X-Sender: "John Pullokkaran" References: <20140910185956.23924.86259@reviews.apache.org> In-Reply-To: <20140910185956.23924.86259@reviews.apache.org> Reply-To: "John Pullokkaran" X-ReviewRequest-Repository: hive-git --===============1209798032280787402== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25513/#review52938 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java Couldn't we introduce a unique alias in Select plan gen when duplicates are found. Then we wouldn't need to add duplicate entries. - John Pullokkaran On Sept. 10, 2014, 6:59 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25513/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 6:59 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-8039 > https://issues.apache.org/jira/browse/HIVE-8039 > > > Repository: hive-git > > > Description > ------- > > Handle repeated alias. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 22295a1 > > Diff: https://reviews.apache.org/r/25513/diff/ > > > Testing > ------- > > limit_pushdown.q > > > Thanks, > > Ashutosh Chauhan > > --===============1209798032280787402==--