Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 761F811D18 for ; Wed, 10 Sep 2014 18:40:17 +0000 (UTC) Received: (qmail 18005 invoked by uid 500); 10 Sep 2014 18:40:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 17920 invoked by uid 500); 10 Sep 2014 18:40:16 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 17905 invoked by uid 99); 10 Sep 2014 18:40:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 18:40:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 096B01DD61B; Wed, 10 Sep 2014 18:40:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2238978932458905700==" MIME-Version: 1.0 Subject: Re: Review Request 25178: Add DROP TABLE PURGE From: "Xuefu Zhang" To: "Xuefu Zhang" Cc: "david seraf" , "Xuefu Zhang" , "hive" Date: Wed, 10 Sep 2014 18:40:15 -0000 Message-ID: <20140910184015.23929.18276@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25178/ X-Sender: "Xuefu Zhang" References: <20140909185130.23924.91831@reviews.apache.org> In-Reply-To: <20140909185130.23924.91831@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============2238978932458905700== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review52911 ----------------------------------------------------------- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Nit: should we just pass ifPurge as boolean to the method unless envContext is also used for something else. This seemingly makes the called method cleaner. - Xuefu Zhang On Sept. 9, 2014, 6:51 p.m., david seraf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25178/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 6:51 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > Add PURGE option to DROP TABLE command to skip saving table data to the trash > > > Diffs > ----- > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java be7134f > hcatalog/webhcat/svr/src/test/java/org/apache/hive/hcatalog/templeton/tool/TestTempletonUtils.java af952f2 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java da51a55 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 9489949 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java a94a7a3 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java cff0718 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cbdba30 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFS.java a141793 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 613b709 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cd017d8 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 4cf98d8 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f31a409 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 32db0c7 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java ba30e1f > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 406aae9 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 1a5ba87 > ql/src/test/queries/clientpositive/drop_table_purge.q PRE-CREATION > ql/src/test/results/clientpositive/drop_table_purge.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/25178/diff/ > > > Testing > ------- > > added code test and added QL test. Tests passed in CI, but other, unrelated tests failed. > > > Thanks, > > david seraf > > --===============2238978932458905700==--