hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8285) Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()
Date Tue, 30 Sep 2014 14:25:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153220#comment-14153220
] 

Ted Yu commented on HIVE-8285:
------------------------------

+1

> Reference equality is used on boolean values in PartitionPruner#removeTruePredciates()
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-8285
>                 URL: https://issues.apache.org/jira/browse/HIVE-8285
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-8285.patch
>
>
> {code}
>       if (e.getTypeInfo() == TypeInfoFactory.booleanTypeInfo
>           && eC.getValue() == Boolean.TRUE) {
> {code}
> equals() should be used in the above comparison.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message