hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8158) Optimize writeValue/setValue in VectorExpressionWriterFactory (in VectorReduceSinkOperator codepath)
Date Thu, 18 Sep 2014 14:09:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138976#comment-14138976
] 

Hive QA commented on HIVE-8158:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12669389/HIVE-8158.1.patch

{color:green}SUCCESS:{color} +1 6279 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/859/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/859/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-859/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12669389

> Optimize writeValue/setValue in VectorExpressionWriterFactory (in VectorReduceSinkOperator
codepath)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-8158
>                 URL: https://issues.apache.org/jira/browse/HIVE-8158
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 0.14.0
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>              Labels: performance
>         Attachments: HIVE-8158.1.patch, profiler_output.png
>
>
> VectorReduceSinkOperator --> ProcessOp --> makeValueWriatable --> VectorExpressionWriterFactory
--> writeValue(byte[], int, int) /setValue.
> It appears that this goes through an additional layer of Text.encode/decode causing CPU
pressure (profiler output attached).
> SettableStringObjectInspector / WritableStringObjectInspector has "set(Object o, Text
value)" method. It would be beneficial to use set(Object, Text) directly to save CPU cycles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message