hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8151) Dynamic partition sort optimization inserts record wrongly to partition when used with GroupBy
Date Tue, 30 Sep 2014 17:57:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153456#comment-14153456
] 

Hive QA commented on HIVE-8151:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12671975/HIVE-8151.7.patch

{color:green}SUCCESS:{color} +1 6374 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1055/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1055/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1055/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12671975

> Dynamic partition sort optimization inserts record wrongly to partition when used with
GroupBy
> ----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-8151
>                 URL: https://issues.apache.org/jira/browse/HIVE-8151
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0, 0.13.1
>            Reporter: Prasanth J
>            Assignee: Prasanth J
>            Priority: Blocker
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8151.1.patch, HIVE-8151.2.patch, HIVE-8151.3.patch, HIVE-8151.4.patch,
HIVE-8151.5.patch, HIVE-8151.6.patch, HIVE-8151.7.patch
>
>
> HIVE-6455 added dynamic partition sort optimization. It added startGroup() method to
FileSink operator to look for changes in reduce key for creating partition directories. This
method however is not reliable as the key called with startGroup() is different from the key
called with processOp(). startGroup() is called with newly changed key whereas processOp()
is called with previously aggregated key. This will result in processOp() writing the last
row of previous group as the first row of next group. This happens only when used with group
by operator.
> The fix is to not rely on startGroup() and do the partition directory creation in processOp()
itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message