hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
Date Sun, 14 Sep 2014 19:56:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133362#comment-14133362
] 

Gopal V commented on HIVE-8090:
-------------------------------

[~rpalamut]: You patch turns off this feature for ZlibCodec, which is the only codec which
implements the modify() operation today.

In this context, I think I missed a null check within the ZlibCodec::modify() check.

Can you add that there instead of disabling the feature?

> Potential null pointer reference in WriterImpl#StreamFactory#createStream()
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-8090
>                 URL: https://issues.apache.org/jira/browse/HIVE-8090
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>         Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch
>
>
> {code}
>       switch (kind) {
> ...
>       default:
>         modifiers = null;
>         break;
>       }
>       BufferedStream result = streams.get(name);
>       if (result == null) {
>         result = new BufferedStream(name.toString(), bufferSize,
>             codec == null ? codec : codec.modify(modifiers));
> {code}
> In case modifiers is null and codec is ZlibCodec, there would be NPE in ZlibCodec#modify(EnumSet<Modifier>
modifiers) :
> {code}
>     for (Modifier m : modifiers) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message