hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7946) CBO: Merge CBO changes to Trunk
Date Mon, 08 Sep 2014 22:57:29 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126251#comment-14126251
] 

Lars Francke commented on HIVE-7946:
------------------------------------

Three options I can think of:

* The checkstyle plugin generates XML reports which can be _relatively_ easily compared. But
this is still a bit painful.
* By far the easiest option I know of is to set up your IDE in a way that it shows you Checkstyle
violations immediately.
* You can use http://www.sonarqube.org/ to generate a nicely formatted report.

The added benefit of option #2 is that you have to do it once and can create "compliant" code
going forward without any additional effort. It helps to get into the habit.

I am not a committer so I think the final decision is up to you. I'd wish for a pre-merge
cleanup though. The [past|https://issues.apache.org/jira/browse/HIVE-6885] has shown that
promised cleanups don't always happen. And clean, documented and standards compliant code
makes it easier for people to understand what's going on. That's especially important for
people who don't have access to in-house committers to pester for information :)

I will try to help in any way. I could for example take a look at the final patch and help
cleaning it up. I just didn't want to waste time on it while it was still in heavy development.

> CBO: Merge CBO changes to Trunk
> -------------------------------
>
>                 Key: HIVE-7946
>                 URL: https://issues.apache.org/jira/browse/HIVE-7946
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>            Reporter: Laljo John Pullokkaran
>            Assignee: Laljo John Pullokkaran
>         Attachments: HIVE-7946.1.patch, HIVE-7946.2.patch, HIVE-7946.3.patch, HIVE-7946.4.patch,
HIVE-7946.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message