hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "skrho (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-7929) close of ZipOutputStream in Utils#jarDir() should be placed in finally block
Date Mon, 01 Sep 2014 11:08:20 GMT

     [ https://issues.apache.org/jira/browse/HIVE-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

skrho updated HIVE-7929:
------------------------
    Attachment: HIVE-7929_001.patch

Here is patch..
I added try/catch/finally statement.. and IZipOutputStream object is closed in finally statement..

Please review my source code.. ^^ Thank you..

> close of ZipOutputStream in Utils#jarDir() should be placed in finally block
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-7929
>                 URL: https://issues.apache.org/jira/browse/HIVE-7929
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.1
>            Reporter: skrho
>            Priority: Minor
>              Labels: patch
>         Attachments: HIVE-7929_001.patch
>
>
> In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , line 308 :
> zos.closeEntry();
> zipDir(dir, relativePath, zos, true);
> zos.close();
> If exception is happened, ZipOutputStream would be left unclosed..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message