hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7863) Potential null reference in TxnDbUtil#prepareDb()
Date Wed, 03 Sep 2014 01:39:52 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119156#comment-14119156
] 

Hive QA commented on HIVE-7863:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12665992/HIVE-7863.1.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6142 tests executed
*Failed tests:*
{noformat}
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/606/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/606/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-606/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12665992

> Potential null reference in TxnDbUtil#prepareDb()
> -------------------------------------------------
>
>                 Key: HIVE-7863
>                 URL: https://issues.apache.org/jira/browse/HIVE-7863
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7863.1.patch
>
>
> Here is related code:
> {code}
>     Connection conn = null;
>     boolean committed = false;
>     try {
>       conn = getConnection();
> ...
>     } finally {
>       if (!committed) conn.rollback();
>       conn.close();
>     }
> {code}
> If getConnection() throws exception, conn.rollback() would be called - leading to NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message