hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 26007: HIVE-8249 - Refactoring SparkPlan and SparkPlanGenerator [Spark Branch]
Date Wed, 24 Sep 2014 23:51:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26007/#review54481
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java
<https://reviews.apache.org/r/26007/#comment94628>

    Nit: could we rename it to IdentityTran, as this has nothing close to union any more?


- Xuefu Zhang


On Sept. 24, 2014, 10:50 p.m., Chao Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26007/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 10:50 p.m.)
> 
> 
> Review request for hive, Brock Noland and Xuefu Zhang.
> 
> 
> Bugs: hive-8249
>     https://issues.apache.org/jira/browse/hive-8249
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently, the code for SparkPlanGenerator seems a little bit messy, and the logic is
not quite clear. This JIRA is created to refactor this and related classes.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/GraphTran.java acd42be 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java 46e4b6d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 7ab2ca0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/UnionTran.java 546b448 
> 
> Diff: https://reviews.apache.org/r/26007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chao Sun
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message