hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 25784: Hive select query hang when fields contain map
Date Tue, 23 Sep 2014 21:44:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25784/#review54339
-----------------------------------------------------------



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java
<https://reviews.apache.org/r/25784/#comment94463>

    minor nit - looks like the formatting of the first assertEquals() from each of your test
cases is off by one space



serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java
<https://reviews.apache.org/r/25784/#comment94464>

    why is this 5 items rather than 4 items, I thought the patch was supposed to skip null
keys/entries?


- Jason Dere


On Sept. 23, 2014, 8:54 p.m., XIAOBING ZHOU wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25784/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 8:54 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> SEE ALSO:
> https://issues.apache.org/jira/browse/HIVE-8115
> 
> 
> Diffs
> -----
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyMap.java 686fc76 
>   serde/src/test/org/apache/hadoop/hive/serde2/lazy/TestLazyArrayMapStruct.java ac0b583

> 
> Diff: https://reviews.apache.org/r/25784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> XIAOBING ZHOU
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message