hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dong Chen" <dong1.c...@intel.com>
Subject Re: Review Request 25834: HIVE-8138 - Global Init file should allow specifying file name not only directory
Date Mon, 22 Sep 2014 02:23:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25834/#review54107
-----------------------------------------------------------



service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
<https://reviews.apache.org/r/25834/#comment94096>

    Shall we add a newline here? To make the coding style better.


The patch looks good! I only have a very small comment here.

- Dong Chen


On Sept. 19, 2014, 5:28 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25834/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 5:28 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Allows either a file or dir.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a045b7 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 5231d5e 
>   service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
5b1cbc0 
> 
> Diff: https://reviews.apache.org/r/25834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message