hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 25754: HIVE-8111 CBO trunk merge: duplicated casts for arithmetic expressions in Hive and CBO
Date Sat, 20 Sep 2014 00:36:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25754/#review54062
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java
<https://reviews.apache.org/r/25754/#comment94010>

    Since DecimalUtility would give you widest type possible for numeric comparisons your
tgtDT would always be func return type.
    
    am i wrong?


- John Pullokkaran


On Sept. 19, 2014, 9:50 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25754/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 9:50 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f17b93d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java
006870c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java 6131d3d

>   ql/src/test/queries/clientpositive/decimal_udf.q 591c210 
>   ql/src/test/results/clientpositive/decimal_udf.q.out c5c2031 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java cc75491

> 
> Diff: https://reviews.apache.org/r/25754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message