hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni" <kulkarni.swar...@gmail.com>
Subject Re: Review Request 25575: HIVE-7615: Beeline should have an option for user to see the query progress
Date Fri, 19 Sep 2014 21:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25575/#review54027
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/25575/#comment93921>

    Nit: Can move the logic inline.



beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/25575/#comment93910>

    Also show we be checking on the SQL error code vs the message. Grepping on the error seems
a little risky.



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
<https://reviews.apache.org/r/25575/#comment93925>

    Nit: Could skip else



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
<https://reviews.apache.org/r/25575/#comment93924>

    Nit: Could skip the else.


- Swarnim Kulkarni


On Sept. 19, 2014, 9:22 a.m., Dong Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25575/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 9:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> When executing query in Beeline, user should have a option to see the progress through
the outputs. Beeline could use the API introduced in HIVE-4629 to get and display the logs
to the client.
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml 45fa02b 
>   beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 1e66542

>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java daf8e9e 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c 
> 
> Diff: https://reviews.apache.org/r/25575/diff/
> 
> 
> Testing
> -------
> 
> UT passed.
> 
> 
> Thanks,
> 
> Dong Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message