hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 25575: HIVE-7615: Beeline should have an option for user to see the query progress
Date Fri, 19 Sep 2014 20:52:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25575/#review54023
-----------------------------------------------------------


Excellent work as usual! I have a few items below but I think is really close!


beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/25575/#comment93899>

    I think in this case it makes sense to turn an empty list as opposed to throwing an exception.
All clients will have to do this same thing we are doing.



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
<https://reviews.apache.org/r/25575/#comment93901>

    if ( not null) {
    
    } else {
    
    is simpler as:
    
    if (null) {
    
    } else {



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
<https://reviews.apache.org/r/25575/#comment93900>

    As mentioned above, in this case let's return an empty list.



jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
<https://reviews.apache.org/r/25575/#comment93902>

    Let's change this to:
    
     throw new SQLException("Error when getting query log: " + e, e);


- Brock Noland


On Sept. 19, 2014, 9:22 a.m., Dong Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25575/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 9:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> When executing query in Beeline, user should have a option to see the progress through
the outputs. Beeline could use the API introduced in HIVE-4629 to get and display the logs
to the client.
> 
> 
> Diffs
> -----
> 
>   beeline/pom.xml 45fa02b 
>   beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 1e66542

>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java daf8e9e 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c 
> 
> Diff: https://reviews.apache.org/r/25575/diff/
> 
> 
> Testing
> -------
> 
> UT passed.
> 
> 
> Thanks,
> 
> Dong Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message