hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 25743: StorageHandler resources aren't added to Tez Session if already Session is already Open
Date Thu, 18 Sep 2014 15:21:35 GMT


> On Sept. 17, 2014, 6:03 p.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java, line 262
> > <https://reviews.apache.org/r/25743/diff/1/?file=692607#file692607line262>
> >
> >     please log error;
> >     in fact, I wonder if it's wise to ignore exceptions. Why not let it thru?

I remember the reason why the error occurs, but I've forgotten if there is a case in which
we could be unknowingly re-adding the local resources to the DAG. I'll test this some more
and get back to you.


> On Sept. 17, 2014, 6:03 p.m., Sergey Shelukhin wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java, line 311
> > <https://reviews.apache.org/r/25743/diff/1/?file=692608#file692608line311>
> >
> >     it's not necessary to copy if any of the lists are null or empty

Noted, will fix and update.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25743/#review53700
-----------------------------------------------------------


On Sept. 17, 2014, 5:56 p.m., Josh Elser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25743/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 5:56 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7950
>     https://issues.apache.org/jira/browse/HIVE-7950
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Was trying to run some queries using the AccumuloStorageHandler when using the Tez execution
engine. Some things that classes which were added to tmpjars weren't making it into the container.
When a Tez Session is already open, as is the normal case when simply using the `hive` command,
the resources aren't added.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 0d0ac41 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 428e0ff 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java 456b5eb 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java ad5a6e7 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 45ab672 
> 
> Diff: https://reviews.apache.org/r/25743/diff/
> 
> 
> Testing
> -------
> 
> Ran ql/ unit tests, tested AccumuloStorageHandler in local deployment after killing tez
session.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message