hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 25595: HIVE-8083: Authorization DDLs should not enforce hive identifier syntax for user or group namesname that
Date Wed, 17 Sep 2014 17:08:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25595/
-----------------------------------------------------------

(Updated Sept. 17, 2014, 5:08 p.m.)


Review request for hive and Brock Noland.


Changes
-------

Addressed review feedback
Used QuotedIdentifier rule directly. This ensures that the back quotes are removed from the
user or group name.
Updated test case.


Bugs: HIVE-8083
    https://issues.apache.org/jira/browse/HIVE-8083


Repository: hive-git


Description
-------

The compiler expects principals (user, group and role) as hive identifiers for authorization
DDLs. The user and group are entities that belong to external namespace and we can't expect
those to follow hive identifier syntax rules. For example, a userid or group can contain '-'
which is not allowed by compiler.
The patch is to allow string literal for user and group names.
The quoted identifier support perhaps can be made to work with this. However IMO this syntax
should be supported regardless of quoted identifier support (which is an optional configuration)


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 25cd3a5 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 34d2dfc 
  ql/src/test/queries/clientpositive/authorization_non_id.q PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_non_id.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/25595/diff/


Testing
-------

Added test case to verify various auth DDLs with new syntax.


Thanks,

Prasad Mujumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message