hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu" <amareshw...@apache.org>
Subject Re: Review Request 25492: HIVE-7936 - Thrift Union support
Date Mon, 15 Sep 2014 06:22:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25492/#review53314
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 11, 2014, 4:26 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25492/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 4:26 p.m.)
> 
> 
> Review request for hive, Amareshwari Sriramadasu and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-7936
>     https://issues.apache.org/jira/browse/HIVE-7936
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> ThriftDeserializer currently does not support UNION types
> 
> 
> Diffs
> -----
> 
>   contrib/src/test/results/clientpositive/udf_example_arraymapstruct.q.out e876cdd 
>   data/files/complex.seq c27d5c09b1da881d8fd6fb2aaa1f5d169d1de3ae 
>   ql/src/test/queries/clientpositive/input_lazyserde.q 69c0d04 
>   ql/src/test/results/clientnegative/describe_xpath1.q.out d81c96e 
>   ql/src/test/results/clientnegative/describe_xpath2.q.out 2bd0f06 
>   ql/src/test/results/clientpositive/case_sensitivity.q.out 8684557 
>   ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out 4805836 
>   ql/src/test/results/clientpositive/input17.q.out 8fff21b 
>   ql/src/test/results/clientpositive/input5.q.out 7524ca7 
>   ql/src/test/results/clientpositive/input_columnarserde.q.out 13cfb7f 
>   ql/src/test/results/clientpositive/input_dynamicserde.q.out ebcf1d8 
>   ql/src/test/results/clientpositive/input_lazyserde.q.out 0f685f2 
>   ql/src/test/results/clientpositive/input_testxpath.q.out 3f4b96e 
>   ql/src/test/results/clientpositive/input_testxpath2.q.out af1e999 
>   ql/src/test/results/clientpositive/input_testxpath3.q.out b31b2f3 
>   ql/src/test/results/clientpositive/input_testxpath4.q.out 3dca8bf 
>   ql/src/test/results/clientpositive/inputddl8.q.out fc13356 
>   ql/src/test/results/clientpositive/join_thrift.q.out e1588c5 
>   ql/src/test/results/clientpositive/udf_case_thrift.q.out 0fc8e84 
>   ql/src/test/results/clientpositive/udf_coalesce.q.out 0d32476 
>   ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out 1f600b4 
>   ql/src/test/results/clientpositive/udf_size.q.out d7a4fa2 
>   ql/src/test/results/clientpositive/union21.q.out 0e47ff4 
>   ql/src/test/results/compiler/plan/case_sensitivity.q.xml c624418 
>   ql/src/test/results/compiler/plan/input5.q.xml a881da3 
>   ql/src/test/results/compiler/plan/input_testxpath.q.xml a3dacdf 
>   ql/src/test/results/compiler/plan/input_testxpath2.q.xml 7fc3a49 
>   serde/if/test/complex.thrift 308b64c 
>   serde/src/gen/thrift/gen-cpp/complex_types.h 17991d4 
>   serde/src/gen/thrift/gen-cpp/complex_types.cpp 9526d3d 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
e36a792 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/PropValueUnion.java
PRE-CREATION 
>   serde/src/gen/thrift/gen-py/complex/ttypes.py 7283e4c 
>   serde/src/gen/thrift/gen-rb/complex_types.rb 5527096 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
9a226b3 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
ee5b0d0 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ThriftObjectInspectorUtils.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ThriftUnionObjectInspector.java
PRE-CREATION 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorUtils.java
a18f4a7 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java
5f692fb 
>   serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java 7269cd0

> 
> Diff: https://reviews.apache.org/r/25492/diff/
> 
> 
> Testing
> -------
> 
> input_lazyserde.q
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message