hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu" <amareshw...@apache.org>
Subject Re: Review Request 25473: Thrift Set type not working with Hive
Date Mon, 15 Sep 2014 06:07:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25473/#review53313
-----------------------------------------------------------

Ship it!


- Amareshwari Sriramadasu


On Sept. 10, 2014, 7:03 a.m., Satish Mittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25473/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2014, 7:03 a.m.)
> 
> 
> Review request for hive, Amareshwari Sriramadasu, Ashutosh Chauhan, and Navis Ryu.
> 
> 
> Bugs: HIVE-7892
>     https://issues.apache.org/jira/browse/HIVE-7892
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Thrift supports List, Map and Struct complex types, which get mapped to Array, Map and
Struct complex types in Hive respectively. However thrift Set type doesn't get mapped to any
Hive type, and hence doesn't work with ThriftDeserializer serde.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/results/beelinepositive/convert_enum_to_string.q.out 24acdcd 
>   ql/src/test/results/clientpositive/convert_enum_to_string.q.out a1ef04f 
>   serde/if/test/complex.thrift 308b64c 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/SetIntString.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
9a226b3 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardListObjectInspector.java
6eb8803 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java
5f692fb 
> 
> Diff: https://reviews.apache.org/r/25473/diff/
> 
> 
> Testing
> -------
> 
> 1) Added Unit test along with the fix.
> 2) Manually tested by creating a table with ThriftDeserializer serde and having thrift
set columns:
>    a) described the table
>    b) issued query to select the set column
> 
> 
> Thanks,
> 
> Satish Mittal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message