hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 25524: HIVE-8047 Lazy char/varchar are not using escape char defined in serde params
Date Fri, 12 Sep 2014 03:22:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25524/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 3:22 a.m.)


Review request for hive and Thejas Nair.


Changes
-------

Allow the lazy char/varchar object inspectors to be cached like the rest of the lazy primitive
OIs are.


Bugs: HIVE-8047
    https://issues.apache.org/jira/browse/HIVE-8047


Repository: hive-git


Description
-------

Update lazy char/varchar to support escape character


Diffs (updated)
-----

  data/files/data_with_escape.txt PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java ae128a9 
  ql/src/test/queries/clientpositive/escape3.q PRE-CREATION 
  ql/src/test/results/clientpositive/escape3.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveChar.java ef469eb 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java bc8d41e 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyString.java 28b3f86 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 1d62422 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveCharObjectInspector.java
65fb1ab 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
c802ed0 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
734b9d8 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveCharObjectInspector.java
c340dcb 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
7bbfd1f 

Diff: https://reviews.apache.org/r/25524/diff/


Testing
-------

New q file test


Thanks,

Jason Dere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message