hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 25245: Support dynamic service discovery for HiveServer2
Date Fri, 12 Sep 2014 01:21:51 GMT


> On Sept. 11, 2014, 7:24 p.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 114
> > <https://reviews.apache.org/r/25245/diff/4-5/?file=684777#file684777line114>
> >
> >     Should we do a 'mkdir -p' equivalent as done in ZookeeperTokenStore.ensurePath
?

Yup, that's a cleaner approach. Adding it for the namespace path though as server znode will
never have path components.


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25245/#review53095
-----------------------------------------------------------


On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25245/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 1:08 p.m.)
> 
> 
> Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair.
> 
> 
> Bugs: HIVE-7935
>     https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5d2e6b0 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java ae128a9 
>   jdbc/pom.xml 1ad13a7 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 
>   jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 6e248d6 
>   jdbc/src/java/org/apache/hive/jdbc/JdbcUriParseException.java PRE-CREATION 
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 58339bf 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientException.java PRE-CREATION 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
0919d2f 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java
59294b1 
>   service/src/java/org/apache/hive/service/cli/CLIService.java a0bc905 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java f5a8f27

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b0bb8be 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 11d25cc 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 2b80adc

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 443c371 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 4067106

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c 
>   service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
66fc1fc 
> 
> Diff: https://reviews.apache.org/r/25245/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message