hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <...@lars-francke.de>
Subject Re: Review Request 25468: HIVE-7777: add CSVSerde support
Date Wed, 10 Sep 2014 07:53:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25468/#review52832
-----------------------------------------------------------



serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java
<https://reviews.apache.org/r/25468/#comment91999>

    Thanks for moving these out. Could you make them static?



serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java
<https://reviews.apache.org/r/25468/#comment92000>

    no need to wrap this



serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java
<https://reviews.apache.org/r/25468/#comment92001>

    missing spaces



serde/src/test/org/apache/hadoop/hive/serde2/TestOpenCSVSerde.java
<https://reviews.apache.org/r/25468/#comment92003>

    There's a couple more puts in this file that can be replaced with setProperty


- Lars Francke


On Sept. 9, 2014, 2:16 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25468/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 2:16 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7777
>     https://issues.apache.org/jira/browse/HIVE-7777
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7777: add CSVSerde support
> 
> 
> Diffs
> -----
> 
>   pom.xml 8973c2b52d0797d1f34859951de7349f7e5b996f 
>   serde/pom.xml f8bcc830cfb298d739819db8fbaa2f98f221ccf3 
>   serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java PRE-CREATION 
>   serde/src/test/org/apache/hadoop/hive/serde2/TestOpenCSVSerde.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25468/diff/
> 
> 
> Testing
> -------
> 
> Unit test
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message