hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <...@lars-francke.de>
Subject Re: Review Request 25468: HIVE-7777: add CSVSerde support
Date Wed, 10 Sep 2014 07:52:55 GMT


> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote:
> > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java, line 151
> > <https://reviews.apache.org/r/25468/diff/1/?file=683467#file683467line151>
> >
> >     I don't quite get this comment. Looking at the two CSVReader constructors they
seem to do the same in this case. From how I understand it this if-statement is not needed.
Same for the newWriter method.
> >     
> >     Maybe I'm missing something?
> 
> cheng xu wrote:
>     The CSVParser will do a check work if the separator, quotechar or escape is the same.
If so, it will throw an exception. For this reason, we have to replace with CSVParser.DEFAULT_ESCAPE_CHARACTER('\')
if the escape is DEFAULT_ESCAPE_CHARACTER('"').

Ahh! I see now. That's a bit weird indeed. Thanks for the explanation.


- Lars


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25468/#review52688
-----------------------------------------------------------


On Sept. 9, 2014, 2:16 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25468/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 2:16 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7777
>     https://issues.apache.org/jira/browse/HIVE-7777
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7777: add CSVSerde support
> 
> 
> Diffs
> -----
> 
>   pom.xml 8973c2b52d0797d1f34859951de7349f7e5b996f 
>   serde/pom.xml f8bcc830cfb298d739819db8fbaa2f98f221ccf3 
>   serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java PRE-CREATION 
>   serde/src/test/org/apache/hadoop/hive/serde2/TestOpenCSVSerde.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25468/diff/
> 
> 
> Testing
> -------
> 
> Unit test
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message