hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 25245: Support dynamic service discovery for HiveServer2
Date Mon, 08 Sep 2014 22:05:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25245/#review52637
-----------------------------------------------------------



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/25245/#comment91510>

    Does Ids.OPEN_ACL_UNSAFE allow anyone can delete this entry ?



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/25245/#comment91513>

    should this be error and not fatal ? Fatal usually indicates that you are going to exit
the program.
    
    https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Level.html#FATAL



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/25245/#comment91514>

    Error log level seems more appropriate here.


- Thejas Nair


On Sept. 8, 2014, 7:43 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25245/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 7:43 a.m.)
> 
> 
> Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair.
> 
> 
> Bugs: HIVE-7935
>     https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 31aeba9 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java ae128a9 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 
>   jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 6e248d6 
>   jdbc/src/java/org/apache/hive/jdbc/JdbcUriParseException.java PRE-CREATION 
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 58339bf 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientException.java PRE-CREATION 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
0919d2f 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java
59294b1 
>   service/src/java/org/apache/hive/service/cli/CLIService.java a0bc905 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java f5a8f27

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b0bb8be 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 11d25cc 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 2b80adc

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 443c371 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 4067106

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c 
>   service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
66fc1fc 
> 
> Diff: https://reviews.apache.org/r/25245/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message