hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 25245: Support dynamic service discovery for HiveServer2
Date Sun, 07 Sep 2014 13:27:32 GMT


> On Sept. 3, 2014, 7:15 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 84
> > <https://reviews.apache.org/r/25245/diff/1/?file=673807#file673807line84>
> >
> >     How big are the zookeeper jars ? If we use zookeeper in this class, I believe
zookeeper jars will always be needed for jdbc driver.
> >     It would be better to have the zookeeper service discovery code in a separate
util class. That way we will need zookeeper jars only if this mode is used.

ZooKeeper jars are about 780KB. I was wondering what is a better option:
1. If dynamic service discovery using ZK is supported, add the following jar(s) to your classpath.
Or
2. The JDBC jar you get is indifferent to this config - always works.

Personally, I am bending towards a simpler client deployment, otherwise 1.) adds one more
knob that needs to be supported/kept updated via documentation. Thoughts?


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25245/#review52139
-----------------------------------------------------------


On Sept. 2, 2014, 10:05 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25245/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 10:05 a.m.)
> 
> 
> Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair.
> 
> 
> Bugs: HIVE-7935
>     https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7935
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java
46044d0 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java
59294b1 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 08ed2e7 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 21c33bc

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 027931e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 0864dfb 
>   service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java
66fc1fc 
> 
> Diff: https://reviews.apache.org/r/25245/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + test cases.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message