hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <chao....@cloudera.com>
Subject Re: Review Request 25404: NPE while reading null decimal value
Date Sat, 06 Sep 2014 00:13:19 GMT


> On Sept. 6, 2014, 12:03 a.m., Lars Francke wrote:
> > Good find! Only two minor style issues. +1

Thanks! Sorry I wasn't paying enough attention to long lines - will fix those.


- Chao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25404/#review52529
-----------------------------------------------------------


On Sept. 5, 2014, 11:54 p.m., Chao Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25404/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 11:54 p.m.)
> 
> 
> Review request for hive, Brock Noland and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8008
>     https://issues.apache.org/jira/browse/HIVE-8008
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Say you have this table dec_test:
> dec                 	decimal(10,0)       	                    
> If the table has a row that is 9999999999.5, and if we do
> select * from dec_test;
> it will crash with NPE:
> 2014-09-05 14:08:56,023 ERROR [main]: CliDriver (SessionState.java:printError(545)) -
Failed with exception java.io.IOException:org.apache.hadoop.hive.ql.metadata.HiveException:
java.lang.NullPointerException
> java.io.IOException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.NullPointerException
>   at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:151)
>   at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1531)
>   at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:285)
>   at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:220)
>   at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:423)
>   at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:792)
>   at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:686)
>   at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:625)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at org.apache.hadoop.util.RunJar.main(RunJar.java:212)
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.NullPointerException
>   at org.apache.hadoop.hive.ql.exec.ListSinkOperator.processOp(ListSinkOperator.java:90)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:796)
>   at org.apache.hadoop.hive.ql.exec.SelectOperator.processOp(SelectOperator.java:87)
>   at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:796)
>   at org.apache.hadoop.hive.ql.exec.TableScanOperator.processOp(TableScanOperator.java:92)
>   at org.apache.hadoop.hive.ql.exec.FetchOperator.pushRow(FetchOperator.java:544)
>   at org.apache.hadoop.hive.ql.exec.FetchOperator.pushRow(FetchOperator.java:536)
>   at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:137)
>   ... 12 more
> Caused by: java.lang.NullPointerException
>   at org.apache.hadoop.hive.serde2.lazy.LazyUtils.writePrimitiveUTF8(LazyUtils.java:265)
>   at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:486)
>   at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serializeField(LazySimpleSerDe.java:439)
>   at org.apache.hadoop.hive.serde2.DelimitedJSONSerDe.serializeField(DelimitedJSONSerDe.java:71)
>   at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:423)
>   at org.apache.hadoop.hive.ql.exec.DefaultFetchFormatter.convert(DefaultFetchFormatter.java:70)
>   at org.apache.hadoop.hive.ql.exec.DefaultFetchFormatter.convert(DefaultFetchFormatter.java:39)
>   at org.apache.hadoop.hive.ql.exec.ListSinkOperator.processOp(ListSinkOperator.java:87)
>   ... 19 more
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 00ea481c2eed84de12815eedb079e965aa2ee701

>   common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 769410d474fdc0ecbd63c7fe8944b2f6d23d5e5a

> 
> Diff: https://reviews.apache.org/r/25404/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chao Sun
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message