hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 24903: HIVE-7682: HadoopThriftAuthBridge20S should not reset configuration unless required
Date Tue, 02 Sep 2014 19:07:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24903/#review52060
-----------------------------------------------------------


Looks fine, a couple of minor comments/suggestions below.


shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/24903/#comment90796>

    I am not sure if this will compile for hadoop 0.20 profile, otherwise you might need a
shim wrapper for getLoginUser()



shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/24903/#comment90795>

    Perhaps we can change pass the AuthenticationMethod directly from the caller to make this
simpler.


- Prasad Mujumdar


On Aug. 20, 2014, 6:48 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24903/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 6:48 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Described in JIRA
> 
> 
> Diffs
> -----
> 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
8b9da7a 
> 
> Diff: https://reviews.apache.org/r/24903/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message