Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Sat, 30 Aug 2014 19:38:53 +0000 (UTC)
From: "Szehon Ho (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12737959.1409361913171.9902.1409427533359@arcas>
In-Reply-To: <JIRA.12737959.1409361913171@arcas>
References: <JIRA.12737959.1409361913171@arcas>
Subject: [jira] [Commented] (HIVE-7921) Fix confusing dead assignment in
 return statement (JavaHiveVarcharObjectInspector)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116535#comment-14116535 ] 

Szehon Ho commented on HIVE-7921:
---------------------------------

I also doubt it, but we can always run locally to verify.  

The last 2 I've seen fail randomly (probably test order issue and should be looked at when there's time); the first one I took a look and it's OOM, I filed HIVE-7924 to try to fix it.


> Fix confusing dead assignment in return statement (JavaHiveVarcharObjectInspector)
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-7921
>                 URL: https://issues.apache.org/jira/browse/HIVE-7921
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7921.1.patch
>
>
> There are multiple instances of something like this {{return o = new HiveVarchar(value, getMaxLength());}} in this class. That's not only confusing but also useless as it doesn't do anything.
> I've removed those assignments and cleaned up the class a bit.


--
This message was sent by Atlassian JIRA
(v6.2#6252)