Return-Path: 
 <dev-return-98262-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6B6EB11713
	for <apmail-hive-dev-archive@www.apache.org>;
 Mon, 18 Aug 2014 23:17:20 +0000 (UTC)
Received: (qmail 46685 invoked by uid 500); 18 Aug 2014 23:17:19 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 46613 invoked by uid 500); 18 Aug 2014 23:17:19 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 46599 invoked by uid 500); 18 Aug 2014 23:17:19 -0000
Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org
Received: (qmail 46596 invoked by uid 99); 18 Aug 2014 23:17:19 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Aug 2014 23:17:19 +0000
Date: Mon, 18 Aug 2014 23:17:19 +0000 (UTC)
From: "Brock Noland (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12733852.1407957689919.27758.1408403839723@arcas>
In-Reply-To: <JIRA.12733852.1407957689919@arcas>
References: <JIRA.12733852.1407957689919@arcas>
Subject: [jira] [Commented] (HIVE-7717) Add .q tests coverage for "union
 all" [Spark Branch]
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101502#comment-14101502 ] 

Brock Noland commented on HIVE-7717:
------------------------------------

Gotcha,

Based on your runs...if the order is not deterministic we can either add an ORDER BY to the query or add the following to the top of the q file:

{noformat}
-- SORT_BEFORE_DIFF
{noformat}

in either case we'd probably want to make the change on trunk and then merge to our branch since the MR outputs would also need to be updated. We'd probably want to remove those tests from this change and add them in a follow-up.

> Add .q tests coverage for "union all" [Spark Branch]
> ----------------------------------------------------
>
>                 Key: HIVE-7717
>                 URL: https://issues.apache.org/jira/browse/HIVE-7717
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>    Affects Versions: spark-branch
>            Reporter: Na Yang
>            Assignee: Na Yang
>         Attachments: HIVE-7717.1-spark.patch, HIVE-7717.2-spark.patch
>
>
> Add automation test coverage for "union all", by searching through the q-tests in "ql/src/test/queries/clientpositive/" for union tests (like union*.q) and verifying/enabling them on spark.
> Steps to do:
> 1.  Enable a qtest <q-test-name>.q in itests/src/test/resources/testconfiguration.properties by adding the .q test files to spark.query.files.
> 2.  Run mvn test -Dtest=TestSparkCliDriver -Dqfile=<q-test-name>.q -Dtest.output.overwrite=true -Phadoop-2 to generate the output (located in ql/src/test/results/clientpositive/spark).  File will be called <q-test-name>.q.out.
> 3.  Check the generated output is good by verifying the results.  For comparison, check the MR version in ql/src/test/results/clientpositive/<q-test-name>.q.out.  The reason its separate is because the explain plan outputs are different for Spark/MR.
> 4.  Checkin the modification to testconfiguration.properties, and the generated q.out file as well.  You only have to generate the output once.



--
This message was sent by Atlassian JIRA
(v6.2#6252)