Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 826C6118D5 for ; Thu, 7 Aug 2014 08:16:12 +0000 (UTC) Received: (qmail 56927 invoked by uid 500); 7 Aug 2014 08:16:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56860 invoked by uid 500); 7 Aug 2014 08:16:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56846 invoked by uid 500); 7 Aug 2014 08:16:11 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 56843 invoked by uid 99); 7 Aug 2014 08:16:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Aug 2014 08:16:11 +0000 Date: Thu, 7 Aug 2014 08:16:11 +0000 (UTC) From: "KangHS (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KangHS updated HIVE-7600: ------------------------- Attachment: HIVE-7600.patch Change the compared method for Boolean's value. - shortcutFunction() - process() > ConstantPropagateProcFactory uses reference equality on Boolean > --------------------------------------------------------------- > > Key: HIVE-7600 > URL: https://issues.apache.org/jira/browse/HIVE-7600 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Attachments: HIVE-7600.patch > > > shortcutFunction() has the following code: > {code} > if (c.getValue() == Boolean.FALSE) { > {code} > Boolean.FALSE.equals() should be used. > There're a few other occurrences of using reference equality on Boolean in this class. -- This message was sent by Atlassian JIRA (v6.2#6252)