Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61FF7118E2 for ; Thu, 21 Aug 2014 20:27:13 +0000 (UTC) Received: (qmail 10301 invoked by uid 500); 21 Aug 2014 20:27:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 10202 invoked by uid 500); 21 Aug 2014 20:27:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 10055 invoked by uid 500); 21 Aug 2014 20:27:12 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 10029 invoked by uid 99); 21 Aug 2014 20:27:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2014 20:27:12 +0000 Date: Thu, 21 Aug 2014 20:27:12 +0000 (UTC) From: "Alan Gates (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-7571) RecordUpdater should read virtual columns from row MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Gates updated HIVE-7571: ----------------------------- Status: Patch Available (was: Open) False alarm. The bug was in code from HIVE-7078 that I was testing on top of this. Switching this back to patch available. > RecordUpdater should read virtual columns from row > -------------------------------------------------- > > Key: HIVE-7571 > URL: https://issues.apache.org/jira/browse/HIVE-7571 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 0.13.0 > Reporter: Alan Gates > Assignee: Alan Gates > Attachments: HIVE-7571.WIP.patch, HIVE-7571.patch > > > Currently RecordUpdater.update and delete take rowid and original transaction as parameters. These values are already present in the row as part of the new ROW__ID virtual column in HIVE-7513, and thus can be read by the writer from there. And the writer will already have to handle skipping ROW__ID when writing, so it needs to be aware of that column anyone. > We could instead read the values from ROW__ID and then remove it from the object inspector in FileSinkOperator, but this will be hard in the vectorization case where rows are being dealt with 10k at a time. > For these reasons it makes more sense to do this work in the writer. -- This message was sent by Atlassian JIRA (v6.2#6252)