Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDF7E11EB4 for ; Fri, 8 Aug 2014 00:42:13 +0000 (UTC) Received: (qmail 76394 invoked by uid 500); 8 Aug 2014 00:42:13 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 76330 invoked by uid 500); 8 Aug 2014 00:42:13 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 76311 invoked by uid 500); 8 Aug 2014 00:42:13 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 76308 invoked by uid 99); 8 Aug 2014 00:42:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 00:42:13 +0000 Date: Fri, 8 Aug 2014 00:42:13 +0000 (UTC) From: "Hive QA (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-7452) Boolean comparison is done through reference equality rather than using equals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090103#comment-14090103 ] Hive QA commented on HIVE-7452: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12660356/HIVE-7452.patch {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 5871 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers org.apache.hadoop.hive.ql.TestDDLWithRemoteMetastoreSecondNamenode.testCreateTableWithIndexAndPartitionsNonDefaultNameNode org.apache.hive.hcatalog.pig.TestOrcHCatLoader.testReadDataPrimitiveTypes org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/215/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/215/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-215/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12660356 > Boolean comparison is done through reference equality rather than using equals > ------------------------------------------------------------------------------ > > Key: HIVE-7452 > URL: https://issues.apache.org/jira/browse/HIVE-7452 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > Attachments: HIVE-7452.patch > > > In Driver#doAuthorization(): > {code} > if (tbl != null && !tableAuthChecked.contains(tbl.getTableName()) && > !(tableUsePartLevelAuth.get(tbl.getTableName()) == Boolean.TRUE)) { > {code} > The above comparison should be done using .equals() method. > The comparison below doesn't evaluate to true: > {code} > Boolean b = new Boolean(true); > if (b == Boolean.TRUE) { > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)