Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1235611EAC for ; Fri, 8 Aug 2014 00:38:13 +0000 (UTC) Received: (qmail 69149 invoked by uid 500); 8 Aug 2014 00:38:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 69075 invoked by uid 500); 8 Aug 2014 00:38:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 68833 invoked by uid 500); 8 Aug 2014 00:38:12 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 68828 invoked by uid 99); 8 Aug 2014 00:38:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 00:38:12 +0000 Date: Fri, 8 Aug 2014 00:38:12 +0000 (UTC) From: "Sushanth Sowmyan (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-7072) HCatLoader only loads first region of hbase table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090099#comment-14090099 ] Sushanth Sowmyan commented on HIVE-7072: ---------------------------------------- That would be developer documentation for pig, not hive, and thus my intention was that it's helpful for other developers that try to make sense of what this jira did. :) The parameter noted there was a workaround for an issue, but this patch makes using that workaround unnecessary, and so, should not need documentation. > HCatLoader only loads first region of hbase table > ------------------------------------------------- > > Key: HIVE-7072 > URL: https://issues.apache.org/jira/browse/HIVE-7072 > Project: Hive > Issue Type: Bug > Affects Versions: 0.14.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Fix For: 0.14.0 > > Attachments: HIVE-7072.2.patch, HIVE-7072.3.patch, HIVE-7072.4.patch > > > Pig needs a config parameter 'pig.noSplitCombination' set to 'true' for it to be able to read HBaseStorageHandler-based tables. > This is done in the HBaseLoader at getSplits time, but HCatLoader does not do so, which results in only a partial data load. > Thus, we need one more special case definition in HCat, that sets this parameter in the job properties if we detect that we're loading a HBaseStorageHandler based table. (Note, also, that we should not depend directly on the HBaseStorageHandler class, and instead depend on the name of the class, since we do not want a mvn dependency on hive-hbase-handler to be able to compile HCatalog core, since it's conceivable that at some time, there might be a reverse dependency.) The primary issue is one of where this code should go, since it doesn't belong in pig (pig does not know what loader behaviour should be, and this parameter is its interface to a loader), and doesn't belong in the HBaseStorageHandler either, since that's implementing a HiveStorageHandler and is connecting up the two. Thus, this should belong to HCatLoader. Setting this parameter across the board results in poor performance for HCatLoader, so it must only be set when using with HBase. > Thus, it belongs in the SpecialCases definition as that was created specifically for these kinds of odd cases, and can be called from within HCatLoader. -- This message was sent by Atlassian JIRA (v6.2#6252)