Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BAECF11E7E for ; Fri, 29 Aug 2014 14:19:55 +0000 (UTC) Received: (qmail 2357 invoked by uid 500); 29 Aug 2014 14:19:49 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 2292 invoked by uid 500); 29 Aug 2014 14:19:49 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 2277 invoked by uid 99); 29 Aug 2014 14:19:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Aug 2014 14:19:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 687FB1DD2DA; Fri, 29 Aug 2014 14:19:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0961120194980310096==" MIME-Version: 1.0 Subject: Re: Review Request 15449: session/operation timeout for hiveserver2 From: "Lars Francke" To: "Navis Ryu" , "Lars Francke" , "Vaibhav Gumashta" , "hive" Date: Fri, 29 Aug 2014 14:19:48 -0000 Message-ID: <20140829141948.17464.18792@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Lars Francke" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15449/ X-Sender: "Lars Francke" References: <20140829090601.17468.71055@reviews.apache.org> In-Reply-To: <20140829090601.17468.71055@reviews.apache.org> Reply-To: "Lars Francke" X-ReviewRequest-Repository: hive-git --===============0961120194980310096== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51882 ----------------------------------------------------------- Ship it! Only minor comments mostly on lines exceeding Checkstyle's configuration. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long lines common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long lines common/src/java/org/apache/hadoop/hive/conf/HiveConf.java long line common/src/java/org/apache/hadoop/hive/conf/Validator.java missing @Override metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java long line metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java long line ql/src/java/org/apache/hadoop/hive/ql/exec/Heartbeater.java This comment needs updating ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java extra space before semicolon service/src/java/org/apache/hive/service/cli/operation/Operation.java "+ -" can be changed to just "-", maybe warrants a comment. - Lars Francke On Aug. 29, 2014, 9:05 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 9:05 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java 4293b7c > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 74bb863 > common/src/java/org/apache/hadoop/hive/conf/Validator.java cea9c41 > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestRetryingHMSHandler.java 39e7005 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 9e3481a > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4e76236 > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 84e6dcd > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 063dee6 > metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java 8287c60 > ql/src/java/org/apache/hadoop/hive/ql/exec/AutoProgressor.java d7323cb > ql/src/java/org/apache/hadoop/hive/ql/exec/Heartbeater.java 7fdb4e7 > ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 5b857e2 > ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java afd7bcf > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 70047a2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java eb2851b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java ebe9f92 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 11434a0 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 46044d0 > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java f636cff > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java db62721 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 3211759 > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java f34b5ad > ql/src/test/results/clientnegative/set_hiveconf_validation2.q.out 33f9360 > service/src/java/org/apache/hadoop/hive/service/HiveServer.java 32729f2 > service/src/java/org/apache/hive/service/cli/CLIService.java ff5de4a > service/src/java/org/apache/hive/service/cli/OperationState.java 3e15f0c > service/src/java/org/apache/hive/service/cli/operation/Operation.java 0d6436e > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 2867301 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java 270e4a6 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 84e1c7e > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 4e5f595 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 7668904 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java 17c1c7b > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 86ed4b4 > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 21d1563 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java d01e819 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > > --===============0961120194980310096==--