Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A964311FB6 for ; Thu, 28 Aug 2014 06:36:33 +0000 (UTC) Received: (qmail 28423 invoked by uid 500); 28 Aug 2014 06:36:26 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28359 invoked by uid 500); 28 Aug 2014 06:36:26 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28147 invoked by uid 99); 28 Aug 2014 06:36:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 06:36:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 33A1F1D4394; Thu, 28 Aug 2014 06:36:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2426551047664892433==" MIME-Version: 1.0 Subject: Re: Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong ownership when HMS setugi is true From: "Thejas Nair" To: "Navis Ryu" , "Vaibhav Gumashta" , "Thejas Nair" Cc: "Venki Korukanti" , "hive" Date: Thu, 28 Aug 2014 06:36:26 -0000 Message-ID: <20140828063626.17468.18198@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/21679/ X-Sender: "Thejas Nair" References: <20140820223319.1308.7115@reviews.apache.org> In-Reply-To: <20140820223319.1308.7115@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============2426551047664892433== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21679/#review51256 ----------------------------------------------------------- itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java please use a name that better indicates that it is a boolean. eg isRemoteMetastore itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java this status is unused - Thejas Nair On Aug. 20, 2014, 10:33 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21679/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 10:33 p.m.) > > > Review request for hive, Navis Ryu, Thejas Nair, and Vaibhav Gumashta. > > > Bugs: HIVE-6245 > https://issues.apache.org/jira/browse/HIVE-6245 > > > Repository: hive-git > > > Description > ------- > > Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object in HiveSessionImplWithUGI. HiveSessionImplWithUGI is created when user impersonation is needed. > > > Diffs > ----- > > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 4502439 > itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2ImpersonationWithRemoteMS.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 51c3f2c > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 39d2184 > > Diff: https://reviews.apache.org/r/21679/diff/ > > > Testing > ------- > > Patch includes a test. > > > Thanks, > > Venki Korukanti > > --===============2426551047664892433==--