Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3B8211571 for ; Wed, 27 Aug 2014 00:55:34 +0000 (UTC) Received: (qmail 35405 invoked by uid 500); 27 Aug 2014 00:55:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 35332 invoked by uid 500); 27 Aug 2014 00:55:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 35318 invoked by uid 99); 27 Aug 2014 00:55:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2014 00:55:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B8431DBFCF; Wed, 27 Aug 2014 00:55:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3068259739202623519==" MIME-Version: 1.0 Subject: Re: Review Request 25086: HIVE-7889 : Query fails with char partition column From: "Mohit Sabharwal" To: "Mohit Sabharwal" , "hive" Date: Wed, 27 Aug 2014 00:55:34 -0000 Message-ID: <20140827005534.17464.15388@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mohit Sabharwal" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25086/ X-Sender: "Mohit Sabharwal" References: <20140827000953.17463.43737@reviews.apache.org> In-Reply-To: <20140827000953.17463.43737@reviews.apache.org> Reply-To: "Mohit Sabharwal" X-ReviewRequest-Repository: hive-git --===============3068259739202623519== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25086/ ----------------------------------------------------------- (Updated Aug. 27, 2014, 12:55 a.m.) Review request for hive. Changes ------- Inc. feedback. Bugs: HIVE-7889 https://issues.apache.org/jira/browse/HIVE-7889 Repository: hive-git Description ------- For a char partition column, JavaHiveCharObjectInspector attempts to cast HiveCharWritable to HiveChar. Similar issue for Varchar was fixed in HIVE-6642. Diffs (updated) ----- ql/src/test/queries/clientpositive/partition_char.q PRE-CREATION ql/src/test/results/clientpositive/partition_char.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java ff114c04f396fa3b51aa6c065ae019dac2db3a81 Diff: https://reviews.apache.org/r/25086/diff/ Testing ------- Added q-test Thanks, Mohit Sabharwal --===============3068259739202623519==--