Return-Path: 
 <dev-return-99432-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D28C511D1D
	for <apmail-hive-dev-archive@www.apache.org>;
 Mon, 25 Aug 2014 19:47:37 +0000 (UTC)
Received: (qmail 2952 invoked by uid 500); 25 Aug 2014 19:47:37 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 2876 invoked by uid 500); 25 Aug 2014 19:47:37 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 2862 invoked by uid 99); 25 Aug 2014 19:47:36 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Aug 2014 19:47:36 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 39A861DBF32;
	Mon, 25 Aug 2014 19:47:37 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4715669196947006869=="
MIME-Version: 1.0
Subject: Re: Review Request 24830: HIVE-7548: Precondition checks should not
 fail the merge task in case of automatic trigger
From: j.prasanth.j@gmail.com
To: "Gunther Hagleitner" <ghagleitner@hortonworks.com>
Cc: j.prasanth.j@gmail.com, "Gopal V" <gopal@hortonworks.com>,
 "hive" <dev@hive.apache.org>
Date: Mon, 25 Aug 2014 19:47:37 -0000
Message-ID: <20140825194737.17464.56168@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: noreply@reviews.apache.org
X-ReviewGroup: hive
X-ReviewRequest-URL: https://reviews.apache.org/r/24830/
X-Sender: noreply@reviews.apache.org
References: <20140825184810.17464.80198@reviews.apache.org>
In-Reply-To: <20140825184810.17464.80198@reviews.apache.org>
Reply-To: j.prasanth.j@gmail.com
X-ReviewRequest-Repository: hive-git

--===============4715669196947006869==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On Aug. 25, 2014, 6:48 p.m., Gopal V wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1549
> > <https://reviews.apache.org/r/24830/diff/1/?file=663983#file663983line1549>
> >
> >     Use named capture in java as much as possible.
> >     
> >     (?<taskId>[0-9]+) etc.

Named capture is supported only in JDK7 and above. Using comments in next patch to maintain compat.


> On Aug. 25, 2014, 6:48 p.m., Gopal V wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1877
> > <https://reviews.apache.org/r/24830/diff/1/?file=663983#file663983line1877>
> >
> >     What about LOAD DATA INPATH?

By "LOAD .. INTO" in comment I meant meant "LOAD DATA INPATH .. INTO TABLE".. Please look at my previous comment for Gunther's question in review board for LOAD DATA example.


- Prasanth_J


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24830/#review51424
-----------------------------------------------------------


On Aug. 19, 2014, 12:29 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24830/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 12:29 a.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> ORC fast merge (HIVE-7509) will fail the merge task in case if any of the precondition checks fail. Precondition check fail is good for "ALTER TABLE .. CONCATENATE" but not for automatic trigger of merge task from conditional resolver. In case if a partition has non-compatible ORC files for merging then the merge task should ignore it and not fail the task.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1d6a93a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeMapper.java beb4f7d 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileMergeMapper.java b36152a 
>   ql/src/test/queries/clientnegative/orc_merge1.q b2d42cd 
>   ql/src/test/queries/clientnegative/orc_merge2.q 2f62ee7 
>   ql/src/test/queries/clientnegative/orc_merge3.q 5158e2e 
>   ql/src/test/queries/clientnegative/orc_merge4.q ad48572 
>   ql/src/test/queries/clientnegative/orc_merge5.q e94a8cc 
>   ql/src/test/queries/clientpositive/orc_merge_incompat1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/orc_merge_incompat2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/orc_merge_incompat1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/orc_merge_incompat2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24830/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>


--===============4715669196947006869==--