Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8641C11DE5 for ; Thu, 21 Aug 2014 22:43:40 +0000 (UTC) Received: (qmail 73668 invoked by uid 500); 21 Aug 2014 22:43:40 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 73603 invoked by uid 500); 21 Aug 2014 22:43:40 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 73587 invoked by uid 99); 21 Aug 2014 22:43:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2014 22:43:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6779B1DBEFA; Thu, 21 Aug 2014 22:43:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3995781171464891474==" MIME-Version: 1.0 Subject: Re: Review Request 24293: HIVE-4629: HS2 should support an API to retrieve query logs From: "Carl Steinbach" To: "Carl Steinbach" , "Dong Chen" , "hive" Date: Thu, 21 Aug 2014 22:43:40 -0000 Message-ID: <20140821224340.15059.97717@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Carl Steinbach" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/24293/ X-Sender: "Carl Steinbach" References: <20140814150946.5174.56835@reviews.apache.org> In-Reply-To: <20140814150946.5174.56835@reviews.apache.org> Reply-To: "Carl Steinbach" X-ReviewRequest-Repository: hive-git --===============3995781171464891474== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24293/#review51230 ----------------------------------------------------------- service/if/TCLIService.thrift Please use // for comments (like the rest of the file). - Carl Steinbach On Aug. 14, 2014, 3:09 p.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24293/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 3:09 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-4629: HS2 should support an API to retrieve query logs > HiveServer2 should support an API to retrieve query logs. This is particularly relevant because HiveServer2 supports async execution but doesn't provide a way to report progress. Providing an API to retrieve query logs will help report progress to the client. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfc681 > service/if/TCLIService.thrift 80086b4 > service/src/gen/thrift/gen-cpp/TCLIService_types.h 1b37fb5 > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp d5f98a8 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TFetchResultsReq.java 808b73f > service/src/gen/thrift/gen-py/TCLIService/ttypes.py 2cbbdd8 > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 93f9a81 > service/src/java/org/apache/hive/service/cli/CLIService.java add37a1 > service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 87c10b9 > service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java f665146 > service/src/java/org/apache/hive/service/cli/FetchType.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/ICLIService.java c569796 > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java c9fd5f9 > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java caf413d > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java fd4e94d > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java ebca996 > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java 05991e0 > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 315dbea > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 0ec2543 > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 3d3fddc > service/src/java/org/apache/hive/service/cli/operation/LogDivertAppender.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java e0d17a1 > service/src/java/org/apache/hive/service/cli/operation/Operation.java 45fbd61 > service/src/java/org/apache/hive/service/cli/operation/OperationLog.java PRE-CREATION > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 21c33bc > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 4c3164e > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d > service/src/java/org/apache/hive/service/cli/session/SessionManager.java 816bea4 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 5c87bcb > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java e3384d3 > service/src/test/org/apache/hive/service/cli/operation/TestOperationLoggingAPI.java PRE-CREATION > > Diff: https://reviews.apache.org/r/24293/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > > --===============3995781171464891474==--